Merged
Conversation
+ remove matplotlib from the dependency list, as it's not needed in the actual SET calculation, but for result plotting and inspection only. - remove matplotlib in pyproject.toml, requirements.txt and setup.py files - move the module import of matplotlib into point.py + add docs/requirements.txt for extra dependencies needed for running notebooks + add tests/requirements.txt for extra dependencies needed for running tests
scottstanie
approved these changes
Aug 16, 2023
| @@ -24,7 +24,6 @@ classifiers=[ | |||
| dependencies = [ | |||
| "numpy", | |||
| "scipy", | |||
Collaborator
There was a problem hiding this comment.
Something we might try after this PR: you can specify the dependencies dynamically with newer setuptool. I didn't include it since I wasn't sure how it would interact with PySold's current setuptools version pinning
https://github.com/opera-adt/dolphin/blob/main/pyproject.toml#L23-L34
Member
Author
There was a problem hiding this comment.
I like this dynamic dependencies setup a lot, it makes a lot of sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove matplotlib from the dependency list, as it's not needed in the actual SET calculation, but for result plotting and inspection only, as described in Cut scikit-image dependency #67.
pyproject.toml,requirements.txtandsetup.pyfilespoint: move the module import of matplotlib from top of the script to inside the functions.add
docs/requirements.txtfor extra dependencies needed for running notebooksadd
tests/requirements.txtfor extra dependencies needed for running testsAfter this PR, we could cut for a maintenance release version 0.3.1 to update the conda-forge recipe.