Skip to content

move packaging and installation requirements to tests/requirements.txt#77

Merged
jhkennedy merged 3 commits intoinsarlab:mainfrom
jhkennedy:fix-76
Nov 30, 2023
Merged

move packaging and installation requirements to tests/requirements.txt#77
jhkennedy merged 3 commits intoinsarlab:mainfrom
jhkennedy:fix-76

Conversation

@jhkennedy
Copy link
Copy Markdown
Collaborator

@jhkennedy jhkennedy commented Nov 30, 2023

@yunjunz this will fix #76, and shouldn't require any docs or CI/CD changes.

Basically, this:

  • changes requirements.txt to be runtime dependencies only
  • changes tests/requirements.txt to be all additional dependencies for development (building, packaging, testing)

which is fine overall (if you're developing, you should be testing!) and coherent with the docs.

Strictly speaking, I don't think you need to list setuptools, setuptools_scm, or wheel as development dependencies as pip will do isolated builds if a pyproject.toml is present and pull the build dependencies from the [build-system] requirements listed there.

But, I do like having setuptools_scm in the dev environment so I can easily check what version it thinks the project is on with:

python -m setuptools_scm

If you're going to keep them, however, it's probably worth including the same pins in the requirements.txt files as pyproject.toml:

requires = ["setuptools<60.0", "setuptools_scm[toml]>=6.2", "numpy<1.23.0", "wheel"]

@jhkennedy jhkennedy requested a review from yunjunz November 30, 2023 05:18
Copy link
Copy Markdown
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clean and nice. Thank you @jhkennedy.

Thanks for the explanation on setuptools and wheel. They are now gone.

Merge it if you think it's ready please.

@jhkennedy jhkennedy merged commit 859149f into insarlab:main Nov 30, 2023
@jhkennedy jhkennedy deleted the fix-76 branch November 30, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip check fails in mintpy-feedstock due to PySolid's setuptools_scm dependency

2 participants