move packaging and installation requirements to tests/requirements.txt#77
Merged
jhkennedy merged 3 commits intoinsarlab:mainfrom Nov 30, 2023
Merged
move packaging and installation requirements to tests/requirements.txt#77jhkennedy merged 3 commits intoinsarlab:mainfrom
jhkennedy merged 3 commits intoinsarlab:mainfrom
Conversation
yunjunz
approved these changes
Nov 30, 2023
Member
There was a problem hiding this comment.
This looks clean and nice. Thank you @jhkennedy.
Thanks for the explanation on setuptools and wheel. They are now gone.
Merge it if you think it's ready please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yunjunz this will fix #76, and shouldn't require any docs or CI/CD changes.
Basically, this:
requirements.txtto be runtime dependencies onlytests/requirements.txtto be all additional dependencies for development (building, packaging, testing)which is fine overall (if you're developing, you should be testing!) and coherent with the docs.
Strictly speaking, I don't think you need to list
setuptools,setuptools_scm, orwheelas development dependencies aspipwill do isolated builds if apyproject.tomlis present and pull the build dependencies from the[build-system]requirements listed there.But, I do like having
setuptools_scmin the dev environment so I can easily check what version it thinks the project is on with:If you're going to keep them, however, it's probably worth including the same pins in the
requirements.txtfiles aspyproject.toml:requires = ["setuptools<60.0", "setuptools_scm[toml]>=6.2", "numpy<1.23.0", "wheel"]