Skip to content

Conversation

@bpugh
Copy link
Contributor

@bpugh bpugh commented Mar 10, 2016

Separates the demo into separate javascript and css files and enables hot reloading via nwb/webpack when running npm start

@iamdustan
Copy link
Collaborator

on 🔥!

iamdustan added a commit that referenced this pull request Mar 10, 2016
Update demo to build with nwb
@iamdustan iamdustan merged commit 6a5f75d into insin:master Mar 10, 2016
@bpugh
Copy link
Contributor Author

bpugh commented Mar 10, 2016

Thanks!
Also I noticed that you might have run the build for the latest version before updating the version number in package.json since when looking at the dist files on npmcdn they have the previous version number in the comment. Not a huge thing but might confuse some users.

@iamdustan
Copy link
Collaborator

Derp. You’re totally right.

screen shot 2016-03-09 at 10 00 30 pm

@bpugh bpugh deleted the update-demo branch March 10, 2016 16:57
@bpugh
Copy link
Contributor Author

bpugh commented Apr 30, 2016

Just thought I'd mention that the dist files still show 3.1.0 even after the 3.1.2 bump.

@iamdustan
Copy link
Collaborator

We removed the dist from git itself. Where is it showing as that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants