Added fixes from the PR board. #53
Conversation
|
what behavior is this intended to change or modify? |
|
@iamdustan I reopned this PR. Looks like the suggestions from the other issues/pr's fixed the issue. |
|
cool. how extensively did you test this, btw? |
|
could you update your commit message to describe the code change more clearly? E.g. |
Right now I'm testing our use case which is rebuilding our checkout pages. I can add it to other fields in the checkout flow. |
|
@iamdustan Do you think we'll be able to get this merged on Monday? |
|
Could you add a test case or two and an example of this to the demo? That’ll make it easier to test out and verify it doesn’t regress in the future. Thanks! |
|
Fair enough. Not sure how to do the test case. Need to see where the On Sun, May 22, 2016 at 7:35 AM, Dustan Kasten notifications@github.com
|
|
I updated the demo and added a test. Let me know what you think. On Sun, May 22, 2016 at 8:00 AM, Martin Phee martyphee@gmail.com wrote:
|
tests/index-test.js
Outdated
| <MaskedInput | ||
| ref={(r) => { | ||
| if (r) ref = r | ||
| }} |
There was a problem hiding this comment.
nit on the spacing here.
|
awesome. Thanks for adding that demo and test case, @martyphee. I’m on PTO a lot this week so won’t be able to test it myself until next week. I’ve asked @jquense to give it a look at his earliest opportunity to get this shipped. Based on his work inside React’s DOM event handling I trust him more than me anyway :) |
|
I fixed up the formatting. @jquense if you have time to review/merge/push that would be great. I have a outstanding PR in our project which depends on this change. Thank you! |
|
LGTM, can you please squash the commits and change the message per: #53 (comment) |
martyphee
force-pushed
the
fix-mask-changes
branch
from
7fb4f1f to
aee2ccf
Compare
|
Done. |
|
@jquense When would you be able to do a release to npm? Thanks for the help. |
|
unfortunately no, I don't have publish rights to npm sorry! |
|
I just added |
|
@insin I only need it to get this published. I might contribute more in the future. |
|
ok published at 3.2.0 |
|
Awesome! Thank you! On Tue, May 24, 2016 at 2:21 PM, Jason Quense notifications@github.com
|
4 participants
Add support for updating the
mask. Fixes #8.Previously the cursor would go to the end of the input if you changed the mask or re-created the MaskedInput field. So, if you have a user typing
34and then switching the mask to1111 111111 11111the cursor would be positioned to the end:34__ ______ _____^.This PR takes suggestions from PR #9.