Silence React 15.4 invalid property warnings #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before passing them to input in order to silence invalid prop warnings introduced in React 15.4
|
We really need this fix in our project. Nothing worse that customers complaining about console errors :) |
Collaborator
|
thanks! |
Contributor
Author
|
Thanks for the excellent component @iamdustan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
planceHolderCharandformatCharactersfrom props before setting them on input element.The specs had
console.errorstubbed out, which may be why the warnings weren't noticed. This restores the spy after it's used and adds an explicit spec to test the props are removed.