[Breaking] ensure Error objects compare properly
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jul 31, 2019
index.js
Outdated
| } | ||
|
|
||
| function isError(value) { | ||
| return value instanceof Error; |
Member
There was a problem hiding this comment.
this won't work cross-realm, i'm afraid.
ljharb
force-pushed
the
feature/support-errors
branch
from
eaa2992 to
bffc3d3
Compare
ljharb
reviewed
Jul 31, 2019
|
|
||
| if (isArguments(a) !== isArguments(b)) { return false; } | ||
|
|
||
| var aIsError = a instanceof Error; |
Member
There was a problem hiding this comment.
rebased and tweaked; here's where this isn't a reliable cross-realm check.
ljharb
changed the title
Error objects compare properly
ljharb
force-pushed
the
feature/support-errors
branch
from
bffc3d3 to
ffb2522
Compare
ljharb
approved these changes
Aug 9, 2019
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I'm going to get this in anyways, despite the lack of a cross-realm brand check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to support
Errorobject. It is easy to cover almost all cases.But it is too difficult to make sure that supporting current supported browsers and nodejs.
Refs:
I felt we should avoid to support to compare
Errorobjects.We might better to put some comments on
README.mdabout that.Fixes #47.
Almost same solution: #48