Skip to content

Job 312 #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ferenc- merged 5 commits into from
Oct 11, 2023
Merged

Job 312 #459

Ferenc- merged 5 commits into from
Oct 11, 2023

Conversation

@Ferenc-
Copy link
Member

@Ferenc- Ferenc- commented Oct 9, 2023

No description provided.

Ferenc- added 2 commits October 9, 2023 10:00
@Ferenc-
test(ci-job): Start testing on 3.12
9d229e4 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
refactor(test): Eliminate superfluous 'nose' dependency in favor of '…
3069851 
…unittest'

Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc- Ferenc- requested review from GSVarsha and pvital October 9, 2023 11:49
pvital
pvital approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GSVarsha
GSVarsha reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we implement the tearDown method to release the resources? (pymongo connection)

@GSVarsha
Copy link
Contributor

GSVarsha commented Oct 10, 2023

Can we move this import statement to the beginning of the file just to be consistent?

@GSVarsha
Copy link
Contributor

GSVarsha commented Oct 10, 2023

Is this relevant anymore provided that we've removed nosetests from our code?

@Ferenc-
Copy link
Member Author

Ferenc- commented Oct 10, 2023

Should we implement the tearDown method to release the resources? (pymongo connection)

Done

@Ferenc-
Copy link
Member Author

Ferenc- commented Oct 10, 2023

Can we move this import statement to the beginning of the file just to be consistent?

For obvisous reasons it can't overtake the environment variable settings, and it's dependent import, but I have moved it to the beginning as much as possible.

@Ferenc-
Copy link
Member Author

Ferenc- commented Oct 10, 2023

Is this relevant anymore provided that we've removed nosetests from our code?

Renamed.

@Ferenc- Ferenc- requested a review from GSVarsha October 10, 2023 11:00
@Ferenc-
refactor(test): Cleanup MongoClient resources + rename client
56d9d22 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
refactor(test): Rename nosetests span name
b3e0a2d 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
refactor(conftest): Move instana import as much to the front as possible
57f0afe 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
GSVarsha
GSVarsha approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Ferenc- Ferenc- merged commit cd76dd8 into master Oct 11, 2023
@Ferenc- Ferenc- deleted the job-312 branch October 11, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

@GSVarsha GSVarsha GSVarsha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ferenc- @GSVarsha @pvital