fix: The spec doesn't set upper limit for ec=1 if code>=500 #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamarastanojevic
approved these changes
Dec 12, 2023
tamarastanojevic
left a comment
tamarastanojevic
left a comment
There was a problem hiding this comment.
Right, anything greater or equal than 500 must be considered as error. LGTM 👍🏻
basti1302
approved these changes
Dec 12, 2023
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Ferenc-
force-pushed
the
fix-error-codes
branch
from
f81438c to
e11144d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote from the spec:
This means that there is no upper limit, and this should apply to custom status codes as well, which might be above
511, or even599.