FastAPI: capture responseHeadersOnEntrySpans #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Ferenc-
reviewed
Dec 29, 2023
Ferenc-
reviewed
Dec 29, 2023
Ferenc-
reviewed
Dec 29, 2023
Ferenc-
requested changes
Dec 29, 2023
Member
Ferenc-
left a comment
Ferenc-
left a comment
There was a problem hiding this comment.
Looking good. I have requested a couple of small changes.
pvital
approved these changes
Jan 2, 2024
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
Besides the one comment, It looks good to me.
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
- capture a list of headers Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastAPI: capture responseHeadersOnEntrySpans
Signed-off-by: Varsha GS varsha.gs@ibm.com