Skip to content

Conversation

@GSVarsha
Copy link
Contributor

Django: capture responseHeadersOnEntrySpans

Signed-off-by: Varsha GS varsha.gs@ibm.com

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha self-assigned this Dec 28, 2023
@GSVarsha GSVarsha requested review from Ferenc- and pvital December 28, 2023 11:19
Copy link
Member

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I have suggested a few minor changes.

- capture a list of headers

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha requested a review from Ferenc- December 29, 2023 13:03
Copy link
Member

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 884edc3 into master Jan 2, 2024
@GSVarsha GSVarsha deleted the django-header-capture branch January 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants