Enhance boto3 instrumentation to capture HTTP headers in all four flavours #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferenc-
reviewed
Jan 29, 2024
Ferenc-
reviewed
Jan 29, 2024
Ferenc-
reviewed
Jan 29, 2024
Ferenc-
reviewed
Jan 29, 2024
Ferenc-
reviewed
Jan 29, 2024
Ferenc-
requested changes
Jan 29, 2024
Member
Ferenc-
left a comment
Ferenc-
left a comment
There was a problem hiding this comment.
The request header extraction should either focus on headers that paricipate in the HTTP call, or should be omitted.
Ferenc-
reviewed
Jan 31, 2024
Ferenc-
reviewed
Jan 31, 2024
Ferenc-
requested changes
Jan 31, 2024
Member
Ferenc-
left a comment
Ferenc-
left a comment
There was a problem hiding this comment.
If we want pursue the extraction from request headers, then we should ensure that it works when the headers are added with event_system.register_first('before-sign.s3.CreateBucket', _add_header).
Ferenc-
reviewed
Feb 1, 2024
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
…ssert statements Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
GSVarsha
force-pushed
the
enhance-boto3-instrumentation
branch
from
89d519c to
06268d2
Compare
Ferenc-
reviewed
Feb 6, 2024
Ferenc-
reviewed
Feb 6, 2024
Ferenc-
reviewed
Feb 6, 2024
Ferenc-
reviewed
Feb 6, 2024
Ferenc-
reviewed
Feb 6, 2024
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enhance boto3 instrumentation to capture HTTP headers in all four flavours
Signed-off-by: Varsha GS varsha.gs@ibm.com
References
Why
According to our spec, tracers SHOULD capture all four flavours of HTTP headers.