Enable Asyncio support. #507
Conversation
pvital
force-pushed
the
enable_asyncio_support
branch
from
3563c47 to
fe679b5
Compare
Ferenc-
left a comment
Ferenc-
left a comment
There was a problem hiding this comment.
In general I see the same tests passing before and after this change.
In order to see that this change has an added value, perhaps we could see some more tests passing? We could enable tornado 6.4 tests and see if this really enables something new which was not possible before.
@Ferenc-, IMO, for a Regarding the support for Tornado > 6.0, this will demand more changes, and I am working on it in a different branch at the moment and will open a new PR for that later. |
pvital
force-pushed
the
enable_asyncio_support
branch
from
fe679b5 to
779021a
Compare
Ferenc-
left a comment
Ferenc-
left a comment
There was a problem hiding this comment.
I do see a lot of value in the findings proven by this PR. Perhaps I was to worried at first.
GSVarsha
left a comment
GSVarsha
left a comment
There was a problem hiding this comment.
My only suggestion would be to move the imports to the top of the file as mentioned in previous comments. Other than that, the PR looks good to me!
As we support now only the Python runtime >= 3.7, the usage of the ContextVarsScopeManager as Tracer's scope manager is indicated to provide automatic Span propagation from parent coroutines, tasks and scheduled in event loop callbacks to their children. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Used ruff (vscode) to: - Black-compatible code formatting. - fix all auto-fixable violations, like unused imports. - isort-compatible import sorting. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
enable_asyncio_support
branch
from
779021a to
a8feb6c
Compare
As we support now only the Python runtime >= 3.7, the usage of the ContextVarsScopeManager as Tracer's scope manager is indicated to provide automatic Span propagation from parent coroutines, tasks and scheduled in event loop callbacks to their children.
Signed-off-by: Paulo Vital paulo.vital@ibm.com