Skip to content

Conversation

@GSVarsha
Copy link
Contributor

What

Run both starlette and gevent tests together in a single job

Why

PR from FastAPI to include the latest starlette version is still not merged

Reference

slack thread: https://instana.slack.com/archives/C05M4RNDPLZ/p1709204882315999

@GSVarsha GSVarsha self-assigned this Mar 17, 2024
@GSVarsha GSVarsha force-pushed the latest-starlette-ci branch from 046f93a to aff04bc Compare March 17, 2024 10:33
@GSVarsha GSVarsha requested review from Ferenc- and pvital March 17, 2024 10:45
@GSVarsha GSVarsha force-pushed the latest-starlette-ci branch 2 times, most recently from 29e25fe to c876a6d Compare March 17, 2024 17:42
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the latest-starlette-ci branch from c876a6d to 44925d8 Compare March 18, 2024 09:25
@GSVarsha GSVarsha requested a review from Ferenc- March 18, 2024 10:10
@GSVarsha GSVarsha added this to the H1-2024 milestone Mar 18, 2024
@GSVarsha
Copy link
Contributor Author

Modified the master branch protection rules to have py39gevent_starlette as a required check.

ERROR: file or directory not found: tests/frameworks/test_gevent.py tests/frameworks/test_starlette.py
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc- Ferenc- merged commit b61a35e into master Mar 18, 2024
@Ferenc- Ferenc- deleted the latest-starlette-ci branch March 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants