Skip to content

Conversation

@Ferenc-
Copy link
Member

@Ferenc- Ferenc- commented May 28, 2024

No description provided.

@Ferenc- Ferenc- requested review from GSVarsha and pvital May 28, 2024 08:15
@Ferenc- Ferenc- force-pushed the pubsub-emulator-image branch from a4a7e37 to e13a57e Compare May 28, 2024 08:16
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but we have to be careful when using non-official images here, even if for testing purposes only.

In the future, we can investigate the use of the cloud CLI and the emulator option, as documented here.

@Ferenc- Ferenc- force-pushed the pubsub-emulator-image branch from e13a57e to 7b00d5c Compare May 28, 2024 08:36
@Ferenc- Ferenc- merged commit 67b43e7 into master May 28, 2024
@Ferenc- Ferenc- deleted the pubsub-emulator-image branch May 28, 2024 09:48
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants