update: added google-cloud-storage v2.18.2 support #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cagri Yonca <cagriyonca@gmail.com>
CagriYonca
force-pushed
the
module_version_update
branch
from
29dcf9e to
b6b3b31
Compare
pvital
reviewed
Aug 23, 2024
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
Python 3.8 will be declared EOL in about two months when 3.13 is released. I prefer to find a way to also support it on 3.11 and 3.12 since these will be used more and more for stable apps.
What happens if we specify on the requirements.txt file for 3.11 and 3.12 the google-api-core >= 2.15.0?
CagriYonca
force-pushed
the
module_version_update
branch
3 times, most recently
from
f27b782 to
23a25f2
Compare
… for python 3.11 and 3.12 Signed-off-by: Cagri Yonca <cagriyonca@gmail.com>
CagriYonca
force-pushed
the
module_version_update
branch
from
23a25f2 to
5e34e95
Compare
Member
|
Wonderful @CagriYonca! Please change the following in addition:
|
CagriYonca
force-pushed
the
module_version_update
branch
3 times, most recently
from
9118791 to
b7dcbb0
Compare
Contributor
Author
|
CagriYonca
force-pushed
the
module_version_update
branch
4 times, most recently
from
fdf4e6b to
0284776
Compare
Signed-off-by: Cagri Yonca <cagriyonca@gmail.com>
CagriYonca
force-pushed
the
module_version_update
branch
from
0284776 to
ccde04b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 and 3.12 has the dependency conflict below:
