Skip to content

Conversation

@CagriYonca
Copy link
Contributor

@CagriYonca CagriYonca commented Oct 3, 2024

I worked on the modules below, increased existing unittests and created non-existing:
•⁠ ⁠src/instana/collector/base.py (98% coverage)
•⁠ ⁠src/instana/collector/helpers/runtime.py (97%)
•⁠ ⁠src/instana/collector/host.py (96%)
•⁠ ⁠src/instana/collector/utils.py (100%)
•⁠ ⁠src/instana/propagators/base_propagator.py (96%)
•⁠ ⁠src/instana/sampling.py (93%)
•⁠ ⁠src/instana/util/traceutils.py (97%)

Modified folder structures in tests folder, used the same structure that src/instana folder has.

@CagriYonca CagriYonca added this to the H2-2024 milestone Oct 3, 2024
@CagriYonca CagriYonca requested review from GSVarsha and pvital October 3, 2024 12:16
@CagriYonca CagriYonca self-assigned this Oct 3, 2024
@github-actions

This comment was marked as resolved.

@CagriYonca CagriYonca force-pushed the otel/unittests branch 4 times, most recently from cd3fc15 to 4ff5db5 Compare October 4, 2024 08:26
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few requests

@CagriYonca CagriYonca force-pushed the otel/unittests branch 2 times, most recently from ce56b02 to 5dbf9ad Compare October 4, 2024 14:28
@CagriYonca CagriYonca requested a review from pvital October 4, 2024 14:33
@CagriYonca CagriYonca force-pushed the otel/unittests branch 2 times, most recently from fdc7208 to b9bf61e Compare October 10, 2024 16:26
@CagriYonca CagriYonca closed this Oct 14, 2024
@CagriYonca CagriYonca reopened this Oct 14, 2024
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit f945a7b into master Oct 15, 2024
@CagriYonca CagriYonca deleted the otel/unittests branch October 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants