codebase: added pre-commit-feature and ruff linter #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CagriYonca
force-pushed
the
pre-commit-feature
branch
3 times, most recently
from
40b6e6d to
9fe367b
Compare
pvital
requested changes
Oct 15, 2024
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
There is no way to review 129 files. Please only commit the pre-commit config file and all the changes to the production code we commit as we touch it in the future.
Also, add the packages ruff and pre-commit as dependencies in the [project.optional-dependencies][dev] list in the pyproject.toml file.
CagriYonca
force-pushed
the
pre-commit-feature
branch
5 times, most recently
from
f83ad96 to
e6b9a85
Compare
CagriYonca
force-pushed
the
pre-commit-feature
branch
3 times, most recently
from
8e1f3f3 to
1ea8d5a
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
pre-commit-feature
branch
from
1ea8d5a to
645cd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented pre-commit-feature and ruff linter. The codebase will be cleaner, easier and in better shape than before.