Fix(currency): Run only starlette tests in gevent_starlette task
#647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvital
requested changes
Oct 8, 2024
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
You can keep the environment variable's name as GEVENT_STARLETTE_TEST to explicitly show that this will run both Starlette and Gevent tests in a separate job and let only line 41 of the conftest.py file be commented.
With that, you can continue running Starlette in a separate job, temporarily prevent Gevent from running, and remove the Starlette tests from the runtime jobs.
GSVarsha
force-pushed
the
currency-report-starlette
branch
9 times, most recently
from
b112b76 to
3879719
Compare
This comment was marked as resolved.
This comment was marked as resolved.
GSVarsha
force-pushed
the
currency-report-starlette
branch
from
cec998c to
5cb3c5a
Compare
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
GSVarsha
force-pushed
the
currency-report-starlette
branch
from
5cb3c5a to
aab2062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run only starlette tests for now in
gevent_starlettetask