Fix(django): Support ASGI requests #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSVarsha
added
bug
enhancement
Review & Merge
OTel_migration
GSVarsha
force-pushed
the
django-asgi-support-otel
branch
from
ced0341 to
1ea5eb7
Compare
- Migrate Django middleware to new-style Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
GSVarsha
force-pushed
the
django-asgi-support-otel
branch
from
1ea5eb7 to
ad1861c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Add support to ASGI requests.
Migrate the Django middleware to conform with the new style, from Django 2.0 onwards. By having a single entrypoint to the middleware, __call__, which is wrapped with sync_to_async just once for async requests, we avoid the issue where a ContextVar cannot be reset from a different context.
P.S.
ASGI support new in 3.0
response.headersnew in 3.2 (needed to extract custom headers)