fix: capturing extra-http-headers from agent config #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CagriYonca
force-pushed
the
fix/custom-http-headers
branch
2 times, most recently
from
0966594 to
ff8d230
Compare
pvital
requested changes
Feb 17, 2025
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
Few grammar corrections, but I am missing unit tests for all these new functions.
Remember, it is a best practice to create unit tests for every new function, even if it's a single-line one. This way, we can guarantee full coverage of our code.
CagriYonca
force-pushed
the
fix/custom-http-headers
branch
3 times, most recently
from
09ee229 to
63704e7
Compare
CagriYonca
force-pushed
the
fix/custom-http-headers
branch
3 times, most recently
from
20b511b to
5eac049
Compare
pvital
approved these changes
Feb 20, 2025
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
It looks good to me.
Great job @CagriYonca!
CagriYonca
force-pushed
the
fix/custom-http-headers
branch
2 times, most recently
from
acfd067 to
1197788
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
fix/custom-http-headers
branch
from
1197788 to
01b2541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra-http-headers support to tracer's agent configuration headers.
https://www.ibm.com/docs/en/instana-observability/current?topic=cha-configuring-host-agents-by-using-agent-configuration-file#capturing-custom-http-headers