Add instrumentation unittests for AWS DynamoDB and refactoring s3 #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvital
requested changes
Feb 24, 2025
Member
pvital
left a comment
pvital
left a comment
There was a problem hiding this comment.
As discussed in our Slack Huddle, let's treat the DynamoDB as a database connection, even still using boto3 (which is handled as an EXIT HTTP call) as a library to code.
CagriYonca
force-pushed
the
ft/dynamodb
branch
4 times, most recently
from
e69acaf to
bc0a65c
Compare
CagriYonca
changed the title
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since AWS DynamoDB is used with the boto3 client, no extra development is needed.