Skip to content

Conversation

@GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Mar 10, 2025

feat: Add Spyne instrumentation

@GSVarsha GSVarsha added this to the H1-2025 milestone Mar 10, 2025
@GSVarsha GSVarsha self-assigned this Mar 10, 2025
@GSVarsha GSVarsha requested a review from a team as a code owner March 10, 2025 07:46
Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Please address @CagriYonca requests.

@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch 2 times, most recently from 075397f to fff7b7a Compare March 13, 2025 10:51
@GSVarsha GSVarsha requested review from CagriYonca and pvital March 13, 2025 10:59
@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch 2 times, most recently from 2aff008 to 4e10256 Compare March 17, 2025 11:08
@GSVarsha GSVarsha changed the title feat: Add Spyne instrumentation (support with standard WSGI wrapper) feat: Add Spyne instrumentation Mar 17, 2025
Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Good Job Varsha!

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor request.

@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch from 4e10256 to eecc4a4 Compare March 19, 2025 15:58
@GSVarsha GSVarsha requested a review from pvital March 19, 2025 16:01
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
- Spyne only supports python < 3.12

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the spyne_instrumentation branch from eecc4a4 to 43e8cac Compare March 20, 2025 11:15
@GSVarsha GSVarsha merged commit 06b545a into main Mar 20, 2025
12 of 15 checks passed
@GSVarsha GSVarsha deleted the spyne_instrumentation branch March 20, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants