Skip to content

fix: changed datetime parsing form isoformat #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pvital merged 1 commit into from
Mar 12, 2025
Merged

fix: changed datetime parsing form isoformat #708

pvital merged 1 commit into from
Mar 12, 2025

Conversation

@CagriYonca
Copy link
Contributor

@CagriYonca CagriYonca commented Mar 12, 2025

Updated currency generation to solve the issue below:

Traceback (most recent call last):
  File "/workspace/python-sensor/.tekton/.currency/scripts/generate_report.py", line 299, in <module>
    main()
  File "/workspace/python-sensor/.tekton/.currency/scripts/generate_report.py", line 264, in main
    get_upstream_version(package, last_supported_version)
  File "/workspace/python-sensor/.tekton/.currency/scripts/generate_report.py", line 103, in get_upstream_version
    latest_version_release_date = datetime.fromisoformat(release_time)
ValueError: Invalid isoformat string: '2024-04-17T20:29:43.675911Z'
Error occurred while generating the python tracer currency report.

@CagriYonca CagriYonca self-assigned this Mar 12, 2025
@CagriYonca CagriYonca requested a review from a team as a code owner March 12, 2025 14:06
@CagriYonca
fix: changed datetime parsing form isoformat
18e269e 
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@CagriYonca CagriYonca force-pushed the fix/currency-generation branch from 4ca35c6 to 18e269e Compare March 12, 2025 16:49
pvital
pvital approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@pvital pvital merged commit 19b6ed5 into main Mar 12, 2025
13 checks passed
@pvital pvital deleted the fix/currency-generation branch March 12, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

Assignees

@CagriYonca CagriYonca

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CagriYonca @pvital