Fix Python 3.14.0 CI failures #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvital
force-pushed
the
fix_py3140_ci_failure
branch
from
da0615f to
950e7ae
Compare
GSVarsha
requested changes
May 8, 2025
Contributor
GSVarsha
left a comment
GSVarsha
left a comment
There was a problem hiding this comment.
Unrelated to this PR, but I guess these lines were copied from ruby-sensor when this file was created. Can we remove them in this PR?
GSVarsha
reviewed
May 8, 2025
pvital
force-pushed
the
fix_py3140_ci_failure
branch
2 times, most recently
from
97801a6 to
4b39ab7
Compare
Member
Author
|
Hello @instana/eng-python. I have adapted the CircleCI configuration file to pull the Python 3.14.0 image from my personal project. As soon as we have this reviewed, I will point to the correct image before merging. The image used now is the same as the one we will build in the GH Action. |
CagriYonca
approved these changes
May 8, 2025
Contributor
CagriYonca
left a comment
CagriYonca
left a comment
There was a problem hiding this comment.
Looks good to me, good job!
GSVarsha
reviewed
May 8, 2025
pvital
force-pushed
the
fix_py3140_ci_failure
branch
3 times, most recently
from
7fafb72 to
7f5233d
Compare
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Type annotation can’t be interpreted for Annotated Declarative Table form. https://docs.sqlalchemy.org/en/20/errors.html#type-annotation-can-t-be-interpreted-for-annotated-declarative-table-form Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
GSVarsha
force-pushed
the
fix_py3140_ci_failure
branch
from
00ad4df to
4fbafe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to fix the CircleCI failure when running the tests on top of Python 3.14.0.
It uses a GitHub Actions workflow to build a container image with all test dependencies and publish it in the GitHub Container Registry every Monday and Wednesday at 00:01. This was pre-tested in a personal repository here.
In addition, this PR modified the CircleCI configuration file to use matrix parameters and point to the new container image as the base image to test Python 3.14.0.