Skip to content

s390x support #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pvital merged 4 commits into from
Jul 1, 2025
Merged

s390x support #755

pvital merged 4 commits into from
Jul 1, 2025

Conversation

@pvital
Copy link
Member

@pvital pvital commented Jun 30, 2025 •
edited
Loading

This PR adds support for s390x (IBM Z).

@pvital pvital self-assigned this Jun 30, 2025
@pvital pvital requested a review from a team as a code owner June 30, 2025 14:02
arjun-rajappa
arjun-rajappa approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@arjun-rajappa arjun-rajappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

GSVarsha
GSVarsha reviewed Jul 1, 2025
View reviewed changes
GSVarsha
GSVarsha reviewed Jul 1, 2025
View reviewed changes
GSVarsha
GSVarsha reviewed Jul 1, 2025
View reviewed changes
GSVarsha
GSVarsha reviewed Jul 1, 2025
View reviewed changes
GSVarsha
GSVarsha requested changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few requests:)

@pvital pvital requested a review from GSVarsha July 1, 2025 07:29
@pvital pvital changed the title S390x support s390x support Jul 1, 2025
GSVarsha
GSVarsha reviewed Jul 1, 2025
View reviewed changes
@pvital pvital requested a review from GSVarsha July 1, 2025 09:30
GSVarsha
GSVarsha approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

pvital added 4 commits July 1, 2025 11:35
@pvital
fix (tests): Skipping tests not supported on s390x.
3958def 
The following tests are not executed in a s390x (Z) environment due to lack of support to run them:

- google-cloud-*: no support to s390x.
- pymongo: only the Enterprise edition is supported in s390x.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
fix: logging stacklevel for s390x.
4f08e06 
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
fix(tests): upgrade sqlalchemy regex pattern for s390x.
622c08c 
This change handles similar OperationalError messages raised by different architectures.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
fix(tests): Skip test_stan_recorder.py on s390x.
9762421 
Avoiding the raise of a NotImplementedError when calling multiprocessing.Queue.qsize().

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital pvital merged commit fd363b2 into instana:main Jul 1, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

@arjun-rajappa arjun-rajappa arjun-rajappa approved these changes

Assignees

@pvital pvital

Labels

Review & Merge unittest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pvital @GSVarsha @arjun-rajappa