Skip to content

[Part 1] feat: Implement Span stack trace specification #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GSVarsha merged 6 commits into from
Dec 4, 2025
Merged

[Part 1] feat: Implement Span stack trace specification #826

GSVarsha merged 6 commits into from
Dec 4, 2025

Conversation

@GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Dec 2, 2025 •
edited
Loading

Add support to INSTANA_STACK_TRACE and INSTANA_STACK_TRACE_LENGTH environment variables configuration:

  • move _add_stack() from start_span() to span.end()
  • move _add_stack() from InstanaTracer to InstanaSpan
temp_image_1764687841740

What to expect in Part 2?

Agent configuration file and local YAML configuration file support for stack trace

@GSVarsha
feat: Add support to INSTANA_STACK_TRACE config
de8e397 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
feat: Apply stack trace spec
a301de5 
- add stack trace in `span.end()`
- move `_add_stack()` to `InstanaSpan`

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha self-assigned this Dec 2, 2025
@GSVarsha
test(stack_trace): Adapt tests to the updated spec
46d6ba7 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha added this to the H1-2026 milestone Dec 3, 2025
@GSVarsha
test: Add stack trace env config tests to options
b92a3b1 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha marked this pull request as ready for review December 3, 2025 10:44
@GSVarsha GSVarsha requested a review from a team as a code owner December 3, 2025 10:44
@GSVarsha
refactor: improve readability by adding more helper methods
6ceaa3c 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
pvital
pvital approved these changes Dec 3, 2025
View reviewed changes
@GSVarsha
refactor: move stack trace functionality into a separate module
7fcd7a5 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha requested a review from pvital December 4, 2025 09:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pvital
pvital approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GSVarsha GSVarsha merged commit 2febebf into main Dec 4, 2025
19 checks passed
@GSVarsha GSVarsha deleted the stack-trace-optin branch December 4, 2025 11:46
@GSVarsha GSVarsha added the FUP Fair Usage Policy label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

Assignees

@GSVarsha GSVarsha

Labels

enhancement feature FUP Fair Usage Policy

Projects

None yet

Milestone

H1-2026

Development

Successfully merging this pull request may close these issues.

3 participants

@GSVarsha @pvital