Add tests for the datamixing ensuring all reqd datasets are mixed appropriately #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrowning
force-pushed
the
test-b
branch
2 times, most recently
from
1cb3639 to
dd9e9c1
Compare
…ropriately Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
This finishes up the good start here to add new datamixing tests for phase07 and phase10, ensuring that we are combining the right datasets and end up with the expected number of output samples in each phase dataset. Signed-off-by: Ben Browning <bbrownin@redhat.com>
Contributor
|
@aakankshaduggal I took the liberty of rebasing this on top of the latest changes and tweaking the logic a bit to get things all passing. If you're happy with this, I think we can take it out of draft and get these additional tests in. |
Member
Author
|
thanks for adding to this @bbrowning |
bbrowning
approved these changes
Jan 27, 2025
Contributor
bbrowning
left a comment
bbrowning
left a comment
There was a problem hiding this comment.
I give this a detailed look when rebasing it to work with the latest changes, and looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.