Skip to content

Conversation

@relyt0925
Copy link
Contributor

@relyt0925 relyt0925 commented Nov 25, 2024

The new FAQ.md file includes detailed explanations and examples on how to estimate the number of synthetic samples produced at various stages of the SDG training process. This addition aims to enhance user understanding of the sample generation methodology.

I believe it's an MVP to resolving: #307

@mergify mergify bot added documentation Improvements or additions to documentation ci-failure labels Nov 25, 2024
@relyt0925 relyt0925 force-pushed the faq-size branch 5 times, most recently from b31ff34 to 1f568eb Compare November 25, 2024 05:06
@mergify mergify bot removed the ci-failure label Nov 25, 2024
@aakankshaduggal aakankshaduggal requested a review from a team December 6, 2024 18:21
For each knowledge leaf node: the formula to estimate the number of produced synthetic samples in the training dataset is:

```text
(total cumulative size of knowledge documents / max document chunk size) * number of qna pairs in the knowledge file leaf node * 30 synthetic samples per qna pair
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this factor in the amount of samples that will be filtered out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobotSail this is an excellent point: it does not since that part is non detemenistic to a certain extent: but folks have been looking to be able to get some guidance on some ball park numbers/ answers to general questions around how the taxonomy is processed through SDG

I should call that out as a disclaimer and will do that

The new FAQ.md file includes detailed explanations and examples on how to estimate the number of synthetic samples produced at various stages of the SDG training process. This addition aims to enhance user understanding of the sample generation methodology.

Signed-off-by: Tyler Lisowski <lisowski@us.ibm.com>
@relyt0925
Copy link
Contributor Author

These are a good initial set of FAQs that we have seen pop up with what I feel (based on my studies of the codebase) are the appropriate answers. More than happy to adjust anything that is inaccurate though based on expert opinion!

Copy link
Contributor

@bbrowning bbrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding our docs! I have a couple of comments, but also a more general question. Do you think it would be better to document most of these things in the instructlab/instructlab repository instead of directly in SDG? The reason I ask is that the questions touch on taxonomy, SDG, training, and the intersection of all these. And the target users here would likely be using the ilab CLI to run these workflows as opposed to SDG directly?

@relyt0925
Copy link
Contributor Author

@bbrowning sorry for delay! Thank you so much for review! I agree with you that maybe there is a better home for this page. I will go ahead and get the comments addressed, we can make sure we are all comfortable with the content: and then we can think on where we want it's home to be!

@mergify mergify bot added the one-approval label Jan 29, 2025
Signed-off-by: Ben Browning <bbrownin@redhat.com>
Copy link
Contributor

@bbrowning bbrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added in the requested changes (cleaning up links, fixing typo) as an additional commit and will go ahead and approve to get this merged.

@mergify mergify bot merged commit 9d9b1a8 into instructlab:main Jan 29, 2025
7 checks passed
@mergify mergify bot removed the one-approval label Jan 29, 2025
@relyt0925
Copy link
Contributor Author

Thank you so much @bbrowning for the assistance! Sorry for the delay hope everything is wonderful with you!

@bbrowning
Copy link
Contributor

All is well, and you're welcome! Sorry it took us so long to get this in, but thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants