-
Notifications
You must be signed in to change notification settings - Fork 55
fix: Restrict docling library versions to resolve dependency issues + update mypy linting packages (backport #434)
#437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cherry-pick of 2e00bb8 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@Mergifyio rebase |
☑️ Nothing to doDetails
|
f159971 to
9e29731
Compare
|
@Mergifyio rebase |
`docling-parse` v3.0.0 contains breaking changes to the syntax, which is currently breaking our builds. Also, `mypy` < v1.14 pulls in the latest version of `pydantic` by default, so this commimt hardcodes the correct span of `pydantic` versions that are compatible with `mypy` < v1.14 Finally, we want to pin `docling[tesserocr]>=2.4.2,<=2.8.3` due to breaking changes in v2.9.0 on 9 Dec 2024. Signed-off-by: Courtney Pacheco <6019922+courtneypacheco@users.noreply.github.com>
✅ Branch has been successfully rebased |
9e29731 to
4bf63b9
Compare
|
@courtneypacheco I had to manually cherry-pick this on top of what mergify created - can you verify the changes look good? |
|
Yes, the changes look good. Thank you! |
|
Merged - thanks for the review! |
docling-parseis automatically pulled in bydoclingas a dependency, and v3.0.0 ofdocling-parsecontains breaking syntax changes that prevent our e2e builds ininstructlabfrom succeeding. See issue in InstructLab here: instructlab/instructlab#2765For now, we will pin
docling-parseto the latest v2 release while we investigate how we can update thedocling-parsesyntax to use the new v3 syntax. We will also pin todocling<=2.8.3because v2.10.0 was updated to usedocling-parse>=3.0.0. See here: https://github.com/DS4SD/docling/releases/tag/v2.10.0 (Docling-parse v2 as default PDF backend)Finally,
mypyis experiencing issues with a breaking upstream change, too. By default,mypypulls in the latest version ofpydantic, which is unfortunately now incompatible withmypyas of its v2.10 release. See:mypytype-checking issues affecting aField'sdefaultvalue ordefault_factoryafter upgrade to 2.10 pydantic/pydantic#10950To workaround this dependency issue, I pinned the related dependency,
pydantic, to<=v2.9.2in ourtox.inifile. This will force our latestmypyto use a compatiblepydantic. However, note that I did also pinmypy>=1.0,<1.14. I did this as a safety measure for when themypymaintainers inevitably fix the issue in v1.14 or later.This is an automatic backport of pull request #434 done by Mergify.