use render method for jinja template, add unit tests #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eshwarprasadS <eshwarprasad.s01@gmail.com>
Signed-off-by: eshwarprasadS <eshwarprasad.s01@gmail.com>
bbrowning
approved these changes
Jan 22, 2025
Contributor
bbrowning
left a comment
bbrowning
left a comment
There was a problem hiding this comment.
The added code comments help clarify what _format_prompt is doing, and I appreciate you testing all branches of the logic with the multiple test cases. Thanks for the thorough and quick fix here!
aakankshaduggal
approved these changes
Jan 22, 2025
Member
aakankshaduggal
left a comment
aakankshaduggal
left a comment
There was a problem hiding this comment.
LGTM, thanks @eshwarprasadS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490
Problem
We changed from using simple python string templates to jinja templates, but missed a few places (
ConditionalLLMBlock) to account for this change, which went unnoticed due to missing test coverage for this.The Solution
.format()to.render(), treating the input to_format_prompt()as a jinjaTemplatetest_format_prompt_with_jinja_templatesandtest_format_prompt_without_selectorthat test the behavior ofTemplate.render()based on the inputs. These tests will fail if there are parts of the code that call to_format_prompt()with a python string argument.