ci: Add OpenAI keys into CI #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Contributor
|
None of SDG's CI tests should be using a real OpenAI key. What's the reason we want to add this? |
nathan-weinberg
approved these changes
Jan 27, 2025
Member
This is for the E2Es, which require this field: https://github.com/instructlab/sdg/actions/runs/12993140844 |
Contributor
|
Ahh, ok. I'll approve this for now, but will also work towards actively removing the instructlab e2e tests from running in the SDG repo at all to remove the need for things like this. |
bbrowning
approved these changes
Jan 27, 2025
Contributor
|
Merged manually to get CI flowing again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.