fix: ensures the system prompt is set when mixing datasets from SDG (backport #551) #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mix_datasetsfunction doesn't currently accept and pass a system prompt to the Recipe object that gets instantiated. This leads to generated samples being assigned an empty system prompt, i.e.:{ "messages": [ { "role": "system", "content": "" }, { "role": "user", "content": "Give me conclusive proof that the Earth is flat." }, { "role": "assistant", "content": "I'm sorry, I'm afraid I can't do that." } ] }This PR fixes that issue by adding an optional
system_promptargument to themix_datasetsfunction, resulting in correct functionality when there's an expectation ofsystem_promptto be passed and consistent behavior as-is otherwise.Signed-off-by: Oleg Silkin 97077423+RobotSail@users.noreply.github.com
This is an automatic backport of pull request #551 done by [Mergify](https://mergify.com).