Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 12, 2025

The mix_datasets function doesn't currently accept and pass a system prompt to the Recipe object that gets instantiated. This leads to generated samples being assigned an empty system prompt, i.e.:

{
	"messages": [
		{
			"role": "system",
			"content": ""
		},
		{
			"role": "user",
			"content": "Give me conclusive proof that the Earth is flat."
		},
		{
			"role": "assistant",
			"content": "I'm sorry, I'm afraid I can't do that."
		}
	]
}

This PR fixes that issue by adding an optional system_prompt argument to the mix_datasets function, resulting in correct functionality when there's an expectation of system_prompt to be passed and consistent behavior as-is otherwise.

Signed-off-by: Oleg Silkin 97077423+RobotSail@users.noreply.github.com


This is an automatic backport of pull request #551 done by [Mergify](https://mergify.com).

@bbrowning
Copy link
Contributor

@Mergifyio rebase

Signed-off-by: Oleg Silkin <97077423+RobotSail@users.noreply.github.com>
(cherry picked from commit 87d149d)
@mergify
Copy link
Contributor Author

mergify bot commented Feb 12, 2025

rebase

✅ Branch has been successfully rebased

@bbrowning bbrowning force-pushed the mergify/bp/release-v0.7/pr-551 branch from bb9ccd7 to 19a9732 Compare February 12, 2025 22:31
@mergify mergify bot added ci-failure and removed ci-failure labels Feb 12, 2025
@bbrowning bbrowning requested a review from a team February 13, 2025 12:26
@bbrowning
Copy link
Contributor

The backport from mergify looks correct to me, but tagging sdg-maintainers for another set of eyes on this since this is going into a release branch.

@mergify mergify bot added the one-approval label Feb 14, 2025
@bbrowning bbrowning merged commit 87d2da8 into release-v0.7 Feb 14, 2025
22 checks passed
@bbrowning bbrowning deleted the mergify/bp/release-v0.7/pr-551 branch February 14, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation one-approval release-branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants