Skip to content

Conversation

@bbrowning
Copy link
Contributor

GitHub Mac runners recently have issues building docling[tesserocr]. Since we really only want to use tesseract for OCR on Linux, adjust our requirements.txt to clarify that and just use regular docling on Macs.

GitHub Mac runners recently have issues building docling[tesserocr]. Since we really only want to use tesseract for OCR on Linux, adjust our requirements.txt to clarify that and just use regular docling on Macs.

Signed-off-by: Ben Browning <bbrownin@redhat.com>
@mergify mergify bot added the dependencies Pull requests that update a dependency file label Feb 12, 2025
@eshwarprasadS
Copy link
Contributor

Good catch, I have been noticing the tests failing recently as well. Thanks for making this change 👍

Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the one-approval label Feb 12, 2025
@mergify mergify bot removed the one-approval label Feb 12, 2025
@bbrowning bbrowning merged commit e2296fb into main Feb 12, 2025
28 checks passed
@bbrowning
Copy link
Contributor Author

@Mergifyio backport release-v0.7

@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2025

backport release-v0.7

✅ Backports have been created

Details

@bbrowning bbrowning deleted the mac-docling-requirements branch February 12, 2025 20:25
bbrowning added a commit that referenced this pull request Feb 12, 2025
Only use docling[tesserocr] on non-Macs (backport #555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants