Skip to content

Conversation

@eshwarprasadS
Copy link
Contributor

Refactor DataProcessor to use centralized encoder class retrieval

  • Removed the encoder class initialization from the DataProcessor constructor.
  • Introduced a centralized method for obtaining encoder classes in the encoders module (addressed messy sys path / dynamic imports).
  • Updated relevant tests to reflect the changes in DataProcessor initialization.
  • Cleaned up unused imports and code related to dynamic encoder imports.

…rieval

- Removed the encoder class initialization from the DataProcessor constructor.
- Introduced a centralized method for obtaining encoder classes in the encoders module.
- Updated relevant tests to reflect the changes in DataProcessor initialization.
- Cleaned up unused imports and code related to dynamic encoder imports.

Signed-off-by: eshwarprasadS <eshwarprasad.s01@gmail.com>
@mergify mergify bot added testing Relates to testing ci-failure labels Apr 21, 2025
Signed-off-by: eshwarprasadS <eshwarprasad.s01@gmail.com>
@mergify mergify bot added ci-failure and removed ci-failure labels Apr 21, 2025
Signed-off-by: eshwarprasadS <eshwarprasad.s01@gmail.com>
@mergify mergify bot removed the ci-failure label Apr 21, 2025
@bbrowning bbrowning merged commit 4f98e68 into instructlab:main Apr 22, 2025
24 checks passed
@bbrowning
Copy link
Contributor

@Mergifyio backport release-v0.8

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2025

backport release-v0.8

✅ Backports have been created

Details

@mergify mergify bot added the one-approval label Apr 22, 2025
eshwarprasadS added a commit that referenced this pull request Apr 22, 2025
Fix subset selection dynamic imports (backport #608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

one-approval testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants