You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-19512
affects: Student
builds: Student
release note: Fixed course sync failure in certain cases.
This an alternative approach on fixing the issue of course sync for accounts with limited rate, failures of rate limit exceeded was addressed in previous PR, but this one is to continue the process of sync in case of accidental failure while downloading an image or file referenced in pages.
Test Plan
Use account mentioned in ticket to test course sync and offline mode. On offline mode, the course modules should load correctly and studio video should also be playing.
Silent data loss on download failures (lines 98-100): .replaceError(with: nil) + .compactMap() silently drops any failed file/image downloads from the replacement map. Offline content will be incomplete without any logging, error handling, or fallback to original URLs. Users won't know which assets failed to sync.
✅ Approved - PR achieves the stated goal of bypassing sync failures to allow sync to complete. However, consider adding logging for observability when assets fail to download for offline mode.
Commit: Merge branch 'chore/MBL-19602-API-RateLimitExceeded-Retrial-Logic-Revised' into bugfix/MBL-19512-Course-Sync-Issue-CanineBehaviorCollege (459fc2b) Build Number: 1003 Built At: Dec 14 20:13 CET (12/14 12:13 PM MST)
Silent failure on file/image downloads: Changed to .replaceError(with: nil) + .compactMap, so failed downloads are silently dropped. Offline content will be incomplete if downloads fail, with no logging or visibility.
Inconsistent error handling: downloadAttachment() still returns AnyPublisher<String, Error>, but parse() now silently succeeds. This behavioral inconsistency could cause issues.
Data loss without observability: Failed downloads filtered out with no fallback or logging. Users get incomplete offline content with no indication of what failed.
✅ Approved - achieves goal of bypassing sync failures, but consider adding logging for observability of lost assets.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: MBL-19512
affects: Student
builds: Student
release note: Fixed course sync failure in certain cases.
This an alternative approach on fixing the issue of course sync for accounts with limited rate, failures of rate limit exceeded was addressed in previous PR, but this one is to continue the process of sync in case of accidental failure while downloading an image or file referenced in pages.
Test Plan
Use account mentioned in ticket to test course sync and offline mode. On offline mode, the course modules should load correctly and studio video should also be playing.
Checklist