[MBL-19555][S/T] Inbox - Fix compose message issue of un-selectable active courses when term ends before course end date #3811
Conversation
…nds before course end date refs: MBL-19555 affects: Student, Teacher builds: Student, Teacher release note: Fixed compose message issue of un-selectable active courses when term ends before course end date
Claude Code ReviewUpdated: 2025-12-14 ✅ Approved Summary: Logic change correctly fixes the course selection issue by prioritizing course |
Release Note:Fixed compose message issue of un-selectable active courses when term ends before course end date Affected Apps: Student, TeacherBuilds: Student, Teacher
|
BuildsCommit: Unit tests (7fbbcd1)
|
rh12
left a comment
rh12
left a comment
There was a problem hiding this comment.
Please add unit test for this
petkybenedek
left a comment
petkybenedek
left a comment
There was a problem hiding this comment.
QA +1
Had to change the term end date in the provided account to reproduce the issue
…-ActiveCourse-AfterTermEnds
Claude Code ReviewUpdated: 2025-12-21 ✅ Approved
|
| if let endDate = item.end_at { | ||
| return endDate < Clock.now | ||
| } else { | ||
| return (item.term?.end_at ?? .distantFuture) < Clock.now | ||
| } |
There was a problem hiding this comment.
Maybe the format below would be more straightforward then the if-else one.
| if let endDate = item.end_at { | |
| return endDate < Clock.now | |
| } else { | |
| return (item.term?.end_at ?? .distantFuture) < Clock.now | |
| } | |
| return (item.end_at ?? item.term?.end_at ?? .distantFuture) < Clock.now |
refs: MBL-19555
affects: Student, Teacher
builds: Student, Teacher
release note: Fixed compose message issue of un-selectable active courses when term ends before course end date
Test Plan
See ticket's description learn about steps to reproduce.
Checklist