Skip to content

Multi version#2396

Merged
matyasf merged 8 commits intov12from
multi_version
Feb 27, 2026
Merged

Multi version#2396
matyasf merged 8 commits intov12from
multi_version

Conversation

@HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Feb 4, 2026

No description provided.

@HerrTopi HerrTopi changed the base branch from master to v12 February 4, 2026 08:49
Copy link
Contributor

@ToMESSKa ToMESSKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would the folder structure look in like a component like Select? It's a bit different from Metric in a way it has additonal layer of folders e.g.:

src/
├── Metric/ 
└── MetricGroup/ 
src/
└── Select/ 
    ├── Group/
    ├── Option/
    └── index.tsx

Like this:

src/
├── Select/
│   ├── 11_5/
│   └── 11_6/
├── Group/
│   ├── 11_5/
│   └── 11_6/
├── Option/
│   ├── 11_5/
│   └── 11_6/
└── exports/
    ├── 11_5.ts 
    └── 11_6.ts

Or like this?

src/
├── Select/
│   ├── 11_5/
│   │   ├── Group/
│   │   └── Option/
│   └── 11_6/
│       ├── Group/
│       └── Option/
└── exports/
    ├── 11_5.ts  
    └── 11_6.ts

Or something else?

@HerrTopi
Copy link
Contributor Author

HerrTopi commented Feb 4, 2026

How would the folder structure look in like a component like Select? It's a bit different from Metric in a way it has additonal layer of folders e.g.:

src/
├── Metric/ 
└── MetricGroup/ 
src/
└── Select/ 
    ├── Group/
    ├── Option/
    └── index.tsx

Like this:

src/
├── Select/
│   ├── 11_5/
│   └── 11_6/
├── Group/
│   ├── 11_5/
│   └── 11_6/
├── Option/
│   ├── 11_5/
│   └── 11_6/
└── exports/
    ├── 11_5.ts 
    └── 11_6.ts

Or like this?

src/
├── Select/
│   ├── 11_5/
│   │   ├── Group/
│   │   └── Option/
│   └── 11_6/
│       ├── Group/
│       └── Option/
└── exports/
    ├── 11_5.ts  
    └── 11_6.ts

Or something else?

Very good catch! I think it depends. If Group and Option is a standalone component, then the first version, if not (e.g.: it's only a subcomponent of Select), the secont version.

matyasf and others added 5 commits February 23, 2026 17:00
For now it only parses V1 components. It also does not parse components that use the new structure
and there are several CSS errors
@HerrTopi HerrTopi force-pushed the multi_version branch 2 times, most recently from 41f209e to 0e92803 Compare February 23, 2026 16:23
@github-actions
Copy link

github-actions bot commented Feb 23, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-02-27 14:35 UTC

if (pkgName && pkgName.startsWith('@instructure/')) {
// Alias package name to its source directory
aliases[pkgName] = pkgPath
// Alias subpath exports (e.g., './latest', './v11_6') to source files.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes in this file are AI generated. They "work" but not double checked by human

@ToMESSKa ToMESSKa self-requested a review February 24, 2026 10:39
Copy link
Contributor

@ToMESSKa ToMESSKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After comparing the local multi-version against https://instructure.design/ I noticed the components above use the v12 design for some reason.

Another problem might be that some of the components virtually look the same so you cannot tell if a component uses the v11 design or v12 design by simply just looking at them. So there might be a component using v12 but looking like a v11 component.

@@ -22,7 +22,7 @@
* SOFTWARE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example shows difference in Button

Image Image

@@ -22,7 +22,7 @@
* SOFTWARE.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus ring seems to be a bit smaller in the multi version vs master:

Image Image

@@ -22,7 +22,7 @@
* SOFTWARE.
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this example in CheckBoxGroup already uses the new icon?
Image

Image

*/

import { Alert } from '@instructure/ui'
import { Alert } from '@instructure/ui/latest'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THE 3.72:1 text looks a bit bigger now in the ColorContrast example
Image

Image


import { Alert } from '@instructure/ui'
import { Alert } from '@instructure/ui/latest'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Enter text text will have some different spacing in ColorPicker

Image Image

@@ -22,7 +22,7 @@
* SOFTWARE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing is tighter between the languages in v11:
Image

Image

@@ -22,7 +22,7 @@
* SOFTWARE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextArea using v12 in example

Image Image

@@ -22,7 +22,7 @@
* SOFTWARE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextArea using v12

Image Image

@@ -22,7 +22,7 @@
* SOFTWARE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on icon sizes ToggleGroup examples are displayed with v12 styling

Image Image

@@ -22,7 +22,7 @@
* SOFTWARE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI information/NutritionFacts uses v12

Image Image

@matyasf matyasf merged commit 0e26be9 into v12 Feb 27, 2026
2 of 7 checks passed
@matyasf matyasf deleted the multi_version branch February 27, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants