Conversation
ToMESSKa
left a comment
There was a problem hiding this comment.
How would the folder structure look in like a component like Select? It's a bit different from Metric in a way it has additonal layer of folders e.g.:
src/
├── Metric/
└── MetricGroup/
src/
└── Select/
├── Group/
├── Option/
└── index.tsx
Like this:
src/
├── Select/
│ ├── 11_5/
│ └── 11_6/
├── Group/
│ ├── 11_5/
│ └── 11_6/
├── Option/
│ ├── 11_5/
│ └── 11_6/
└── exports/
├── 11_5.ts
└── 11_6.ts
Or like this?
src/
├── Select/
│ ├── 11_5/
│ │ ├── Group/
│ │ └── Option/
│ └── 11_6/
│ ├── Group/
│ └── Option/
└── exports/
├── 11_5.ts
└── 11_6.ts
Or something else?
Very good catch! I think it depends. If Group and Option is a standalone component, then the first version, if not (e.g.: it's only a subcomponent of Select), the secont version. |
b5e3697 to
f496410
Compare
43d9eac to
fd26415
Compare
… not include functional components
For now it only parses V1 components. It also does not parse components that use the new structure and there are several CSS errors
…ort (now withStyleLegacy)
41f209e to
0e92803
Compare
|
0e92803 to
7c17c12
Compare
| if (pkgName && pkgName.startsWith('@instructure/')) { | ||
| // Alias package name to its source directory | ||
| aliases[pkgName] = pkgPath | ||
| // Alias subpath exports (e.g., './latest', './v11_6') to source files. |
There was a problem hiding this comment.
All the changes in this file are AI generated. They "work" but not double checked by human
ToMESSKa
left a comment
There was a problem hiding this comment.
After comparing the local multi-version against https://instructure.design/ I noticed the components above use the v12 design for some reason.
Another problem might be that some of the components virtually look the same so you cannot tell if a component uses the v11 design or v12 design by simply just looking at them. So there might be a component using v12 but looking like a v11 component.
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||
| */ | |||
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||
| */ | |||
|
|
|||
| */ | ||
|
|
||
| import { Alert } from '@instructure/ui' | ||
| import { Alert } from '@instructure/ui/latest' |
|
|
||
| import { Alert } from '@instructure/ui' | ||
| import { Alert } from '@instructure/ui/latest' | ||
|
|
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||
| @@ -22,7 +22,7 @@ | |||
| * SOFTWARE. | |||




















No description provided.