Open
Conversation
git-nandor
force-pushed
the
INSTUI-4797_modal_rework
branch
from
7910585 to
25e284a
Compare
|
git-nandor
force-pushed
the
INSTUI-4797_modal_rework
branch
3 times, most recently
from
8e32fac to
c378e2d
Compare
git-nandor
force-pushed
the
INSTUI-4797_modal_rework
branch
from
c378e2d to
d842c97
Compare
…padding tokens, body padding prop behaviour is preserved
ToMESSKa
approved these changes
Feb 26, 2026
| @@ -575,11 +571,11 @@ class Example extends React.Component { | |||
| > | |||
Contributor
There was a problem hiding this comment.
Looks good!
One tiny thing, in the new rebrand-light theme, the modal body's bottom corners look curved too. I think this was an issue in v11 too, but less visible because the border radius is much smaller in the canvas theme.
Collaborator
There was a problem hiding this comment.
Sorry I didn't see this one before I wrote my review comment 😅
ToMESSKa
approved these changes
Feb 26, 2026
adamlobler
requested changes
Feb 26, 2026
Collaborator
adamlobler
left a comment
adamlobler
left a comment
There was a problem hiding this comment.
The content has the same border radius at the bottom as the modal itself, but it shouldn't have any border radius, it's an issue on the original component as well but now its more obvious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.