[v12] feat(ui-side-nav-bar): SideNavBar rework#2418
Open
git-nandor wants to merge 1 commit intov12from
Open
Conversation
|
git-nandor
force-pushed
the
INSTUI-4938_SideNavBar_rework
branch
4 times, most recently
from
e6613ec to
36e5904
Compare
git-nandor
force-pushed
the
INSTUI-4938_SideNavBar_rework
branch
from
36e5904 to
008ebc4
Compare
ToMESSKa
requested changes
Feb 26, 2026
| '&:focus': { | ||
| backgroundColor: componentTheme.selectedBackgroundColor, | ||
| boxShadow: `${componentTheme.selectedOuterFocusOutline}, ${componentTheme.selectedInnerFocusOutline}`, | ||
| boxShadow: `${componentTheme.selectedOuterFocusOutlineColor}, ${componentTheme.selectedInnerFocusOutlineColor}`, |
Contributor
There was a problem hiding this comment.
The focus outlines don't seem to work on the items.
Note that in the deleted theme.ts, these were full box shadow strings:
outerFocusOutline: `inset 0 0 0 0.125rem ${colors?.contrasts?.grey4570}`,
innerFocusOutline: `inset 0 0 0 0.25rem ${colors?.contrasts?.white1010}`,
in v11:
v12:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4938
Summary
Migrated SideNavBar component from the old theming system.
Test plan
On the documentation page, verify that everything displays and works correctly.
Co-Authored-By: 🤖 Claude