fix(emotion): fix getShortHandValue not trimming input string#2497
Merged
fix(emotion): fix getShortHandValue not trimming input string#2497
Conversation
the fix trims whitespace from the end/beginning. It also handles correctly if there are multiple whitespaces in the middle INSTUI-4981
matyasf
commented
Apr 1, 2026
| expect(r5).toEqual('15px .2rem') | ||
| }) | ||
|
|
||
| it('trims whitespaces correctly', () => { |
Collaborator
Author
There was a problem hiding this comment.
these cases were throwing warnings and emitting the wrong number of results
|
ToMESSKa
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the fix trims whitespace from the end/beginning. It also handles correctly if there are multiple whitespaces in the middle
Fixes INSTUI-4981