Multiple patches for fixes to pulsar #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 11, 2019 11:34
Fixes apache#5360 This adds a small cache of the request body to ensure that it can be re-sent. TODO: still needs tested
This commit adds a new argument for functions, customRuntimeOptions, which is passed to funcions (as well as sources/sinks) that enables the ability to customize the runtime. This is added primarily to support the `KubernetesManifestCustomizer` interface. This interface has a default implementation, which allows for changing the namespace, labels, and annotations per function. This interface is also pluggable, allowing for more customizable implementations. For example, the functions for a given tenant could be mapped to different pools of compute for isolation.
Currently, if a user has TLS enabled and is using a custom CA that isn't baked into the image, when the functions worker starts, it won't have the CA in order to validate the cert presented by the broker. This adds support to have the `KubernetesSecretsTokenAuthProvider` also distribute the CA via the same kubernetes secret used for the token. a thing
|
Addison Higham seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
addisonj
changed the title
feathj
approved these changes
Oct 21, 2019
| public KubernetesSecretsTokenAuthProvider(CoreV1Api coreClient, String kubeNamespace, byte[] caBytes) { | ||
| this.coreClient = coreClient; | ||
| this.kubeNamespace = kubeNamespace; | ||
| this.caBytes = caBytes; |
There was a problem hiding this comment.
This is a nice workaround. Custom baking images with the CA would have been a pain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are everything that I have fixed over the last few weeks...
All of these commits have changes open upstream: