Fix #46: Add __version__ #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
martindurant
approved these changes
Mar 16, 2022
Member
martindurant
left a comment
martindurant
left a comment
There was a problem hiding this comment.
This seems like a good idea.
| class SnappyModuleTest(TestCase): | ||
| def test_version(self): | ||
| assert tuple(map(int, snappy.__version__.split("."))) >= (0, 6, 1) | ||
| # Make sure that __version__ is identical to the version defined in setup.py |
Member
There was a problem hiding this comment.
It is good to test that it is the same, as it should be. Some projects use external tools like versioneer or poetry to keep these in sync. Here, it would be manual.
| #include <snappy-c.h> | ||
| #include "crc32c.h" | ||
|
|
||
| #define MODULE_VERSION "0.4.1" |
Member
There was a problem hiding this comment.
Note: this incorrect string is currently available as snappy._snappy.__version__
2 tasks
Closed
ewianda
pushed a commit
to benchsci/python-snappy
that referenced
this pull request
Oct 22, 2023
Fix intake#46: Add __version__
ewianda
pushed a commit
to benchsci/python-snappy
that referenced
this pull request
Oct 22, 2023
Fix intake#46: Add __version__
ewianda
pushed a commit
to benchsci/python-snappy
that referenced
this pull request
Oct 22, 2023
Fix intake#46: Add __version__
ewianda
pushed a commit
to benchsci/python-snappy
that referenced
this pull request
Oct 22, 2023
Fix intake#46: Add __version__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.