Allow python-snappy to be compiled in Windows #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since MSVC only allows the inline keyword to be used on .cpp files, it is needed to check if _MSC_VER is defined, so it can be detected if the compiler is MSVC and use the vendor-specific __inline keyword instead. Without this change, the only way to compile python-snappy is to download the source code, make the change and compile/install manually.
Member
|
Would be very happy to include this if someone can confirm for me that it works, without affecting builds on osx/linux. |
Member
|
Same as #55 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MSVC only allows the inline keyword to be used on .cpp files, it is needed to check if _MSC_VER is defined, so it can be detected if the compiler is MSVC and use the vendor-specific __inline keyword instead. Without this change, the only way to compile python-snappy is to download the source code, make the change and compile/install manually.