Bump go-github to v62 + fixes#2304
Merged
kfcampbell merged 14 commits intointegrations:mainfrom Jul 3, 2024
EttoreFoti:f-bump_go_github_v62
Merged
Bump go-github to v62 + fixes#2304kfcampbell merged 14 commits intointegrations:mainfrom EttoreFoti:f-bump_go_github_v62
kfcampbell merged 14 commits intointegrations:mainfrom
EttoreFoti:f-bump_go_github_v62
Conversation
…n_template): broken include_claim_keys test
…ization_template): adjust broken references in tests
kfcampbell
reviewed
Jul 1, 2024
Contributor
kfcampbell
left a comment
kfcampbell
left a comment
There was a problem hiding this comment.
Thank you for your effort here! I'm looking forward to getting this in.
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, | ||
| "release_id": { |
Contributor
There was a problem hiding this comment.
How come this additional schema is added in this PR? Shouldn't there be a corresponding docs change for this as well?
Contributor
Author
There was a problem hiding this comment.
They are already in the docs as attribute reference, they were missing from the schema I guess because it was allowed in older tf sdk versions but as of today the resource is breaking and this is fixing it. The attributes are all computed and so only attribute reference, not parameters.
kfcampbell
approved these changes
Jul 3, 2024
Contributor
kfcampbell
left a comment
kfcampbell
left a comment
There was a problem hiding this comment.
This is awesome, thank you for updating!
1 task
kireque
referenced
this pull request
in kireque/home-ops-old
Jul 9, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | patch | `6.2.2` -> `6.2.3` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v6.2.3`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v6.2.3) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v6.2.2...v6.2.3) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🛠️ Maintenance - build(deps): bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2303](https://togithub.com/integrations/terraform-provider-github/pull/2303) ##### 🏷 Other Changes - fix: Fixing `enterprise_id` import on `github_enterprise_actions_permissions` by [@​ErikElkins](https://togithub.com/ErikElkins) in [https://github.com/integrations/terraform-provider-github/pull/2274](https://togithub.com/integrations/terraform-provider-github/pull/2274) - Bump go-github to v62 + fixes by [@​EttoreFoti](https://togithub.com/EttoreFoti) in [https://github.com/integrations/terraform-provider-github/pull/2304](https://togithub.com/integrations/terraform-provider-github/pull/2304) - docs: mark enterprise runner visibility required by [@​gustavlasko](https://togithub.com/gustavlasko) in [https://github.com/integrations/terraform-provider-github/pull/2278](https://togithub.com/integrations/terraform-provider-github/pull/2278) #### New Contributors - [@​gustavlasko](https://togithub.com/gustavlasko) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2278](https://togithub.com/integrations/terraform-provider-github/pull/2278) **Full Changelog**: integrations/terraform-provider-github@v6.2.2...v6.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
4 tasks
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is updating the core go-github package from v57 to v62 and adjusting all the resources impacted to be backwards compatible.
This is also fixing tests that were previously broken, covering most of the resources, this would be a new activity to plan IMHO.
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!