Modified CLI arg parsing to use Java URL methods#2
Open
mestizo wants to merge 1 commit intointegrissecurity:masterfrom
Open
Modified CLI arg parsing to use Java URL methods#2mestizo wants to merge 1 commit intointegrissecurity:masterfrom
mestizo wants to merge 1 commit intointegrissecurity:masterfrom
Conversation
Owner
|
Thank you for the commit. Its important that we have backward comparability. I know certain institutions rely on having the URI split into parts. I would like to use your code commit but need to rewrite it to ensure that existing installations will not break. I'll have some time later today, possibly, to work on this so that your code can be merged. Thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the methods of the java.net URL class, I've changed the CLI parsing to accept the URL as a single argument. It then parses out the respective parts of the URL. So instead of "http www.site.com 80 /folder" you can now just pass a single argument of: http://www.site.com/admin/ or https://www.site.com:8443/admin/