Conversation
OverOrion
force-pushed
the
szp/polkadot-v0.9.29
branch
from
0cb0fbf to
7911c80
Compare
OverOrion
force-pushed
the
szp/polkadot-v0.9.29
branch
2 times, most recently
from
f2d848f to
4d96624
Compare
runtime/Cargo.toml
Outdated
| pallet-sidechain = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "master" } | ||
| pallet-teeracle = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "master" } | ||
| pallet-teerex = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "master" } | ||
| pallet-claims = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "szp/polkadot-v0.9.29" } |
There was a problem hiding this comment.
Should point to master once integritee-network/pallets#103 has been merged.
haerdib
left a comment
haerdib
left a comment
There was a problem hiding this comment.
LGTM. One question left, but I think it should be fine either way.
| frame_system::ChainContext<Runtime>, | ||
| Runtime, | ||
| AllPalletsReversedWithSystemFirst, | ||
| AllPalletsWithSystem, |
There was a problem hiding this comment.
Is AllPalletsReversedWithSystemFirst not available anymore?
There was a problem hiding this comment.
It is, but deprecated, and gives a warning if used.
If it should stay then let me know and I'll revert this patch.
There was a problem hiding this comment.
Ah. No, that's fine then. But can you add this specific change to the PR description? It should not, but it might affect the worker.
Regex used: Search: \(([\d_]+) as Weight\)\n Replace: Weight::from_ref_time($1)
Signed-off-by: orion <szilard.parrag@gmail.com>
…stem` or `AllPalletsWithoutSystem`
…g reverse pallet orders is deprecated. use only
OverOrion
force-pushed
the
szp/polkadot-v0.9.29
branch
from
85cc438 to
0889a2f
Compare
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Nice, looks good to me!
This does not affect the worker, I believe it is only relevant for some specific edge cases where the order of the pallets-matter for the runtime-internal logic.
The only thing, I don't know if a runtime upgrade can be bricked due to such a change in the order. This, we need to check if we run into this in the parachain.
3 participants
Using reverse pallet orders is deprecated, which is why
AllPalletsReversedWithSystemFirsthas been changed toAllPalletsWithSystem.This may affect the worker, but it should not.