update dependencies to polkadot-v0.9.32#159
update dependencies to polkadot-v0.9.32#159clangenb merged 13 commits intointegritee-network:masterfrom
Conversation
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks very clean. I only have a few minor remarks.
|
|
||
| let import_queue = | ||
| sc_consensus_aura::import_queue::<AuraPair, _, _, _, _, _, _>(ImportQueueParams { | ||
| sc_consensus_aura::import_queue::<AuraPair, _, _, _, _, _>(ImportQueueParams { |
There was a problem hiding this comment.
I always love it, when a parameters disappears. :D
| list_benchmark!(list, extra, pallet_utility, Utility); | ||
| list_benchmark!(list, extra, pallet_teeracle, Teeracle); | ||
| list_benchmark!(list, extra, pallet_sidechain, Sidechain); | ||
| list_benchmarks!(list, extra); |
There was a problem hiding this comment.
Nice, thanks for the improvement here.
| // // Storage: Multisig Multisigs (r:1 w:1) | ||
| // // Storage: Multisig Calls (r:1 w:1) | ||
| // // Storage: unknown [0x3a65787472696e7369635f696e646578] (r:1 w:0) | ||
| // fn as_multi_create_store(s: u32, z: u32, ) -> Weight { | ||
| // Weight::from_ref_time(111_754_000) | ||
| // // Standard Error: 282_000 | ||
| // .saturating_add(Weight::from_ref_time(956_000)).saturating_mul(s.into()) | ||
| // // Standard Error: 0 | ||
| // .saturating_add(Weight::from_ref_time(6_000)).saturating_mul(z.into()) | ||
| // .saturating_add(T::DbWeight::get().reads(3)) | ||
| // .saturating_add(T::DbWeight::get().writes(2)) | ||
| // } |
There was a problem hiding this comment.
If the calls don't exist anymore, please just delete them.
runtime/src/weights/pallet_proxy.rs
Outdated
| .saturating_add(T::DbWeight::get().reads(1 as u64)) | ||
| .saturating_add(T::DbWeight::get().writes(1 as u64)) | ||
| } | ||
| // // Storage: unknown [0x3a65787472696e7369635f696e646578] (r:1 w:0) |
There was a problem hiding this comment.
Same, please delete them.
runtime/src/lib.rs
Outdated
| pub mod currency { | ||
| pub type Balance = u128; | ||
|
|
||
| pub const UNIT: Balance = 1_000_000_000_000; | ||
| pub const DOLLARS: Balance = UNIT; // 1_000_000_000_000 | ||
| pub const CENTS: Balance = DOLLARS / 100; // 10_000_000_000 | ||
| pub const MILLICENTS: Balance = CENTS / 1_000; // 10_000_000 | ||
|
|
||
| /// The existential deposit. | ||
| pub const EXISTENTIAL_DEPOSIT: Balance = 10 * CENTS; | ||
| } | ||
| use crate::currency::DOLLARS; |
There was a problem hiding this comment.
We use TEERs instead of dollars, see:
integritee-node/runtime/src/lib.rs
Line 179 in 91d9ba5
So, you can delete this. If DOLLARS is needed below, you can replace the value with TEER
|
The CI seems to want the protobuf compiler now. According to the substrate docs, it can be installed with: sudo apt install --assume-yes protobuf-compilerIt would be super cool, if you can add this to the CI. |
BillyWooo
changed the title
|
Hmm, this error is weird, do we need to update srtool maybe? |
|
The srtool, from log, is already the latest version. Also not the |
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Wow, I am amazed by the fix. Good catch!
| pub BlockWeights: frame_system::limits::BlockWeights = | ||
| frame_system::limits::BlockWeights::with_sensible_defaults( | ||
| (2u64 * WEIGHT_PER_SECOND).set_proof_size(u64::MAX), | ||
| NORMAL_DISPATCH_RATIO, | ||
| ); |
There was a problem hiding this comment.
How did you find our what you need to do to solve this? I am now having the same issue on the parachain, but my weight declaration is the same as statemines
There was a problem hiding this comment.
3 participants
As title:
TODO: please update benchmark file accordingly.