Merged
Conversation
echevrier
force-pushed
the
83/upgrade_substrate_dep_v14
branch
from
3eab5b7 to
1fd5a43
Compare
haerdib
approved these changes
Nov 9, 2021
Collaborator
haerdib
left a comment
haerdib
left a comment
There was a problem hiding this comment.
LGTM, as long as we don't merge yet :)
runtime/src/weights/pallet_teerex.rs
Outdated
| // Storage: Teerex WorkerForShard (r:0 w:1) | ||
| // Storage: Teerex LatestIpfsHash (r:0 w:1) | ||
| fn confirm_call() -> Weight { | ||
| fn confirm_processed_parentchainblock() -> Weight { |
Collaborator
There was a problem hiding this comment.
That one is already outdated again. But I'll have to do an upgrade to pallet_teerex anyway to finish integritee-network/worker#457, so leave it for now. We just need to make sure we don't downgrade once we're ready to merge this one.
clangenb
reviewed
Nov 11, 2021
Collaborator
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Looks good to me, but I guess, we will have to wait a bit more until merging....
echevrier
force-pushed
the
83/upgrade_substrate_dep_v14
branch
2 times, most recently
from
ae2833b to
86da514
Compare
…: exit status: 1
echevrier
force-pushed
the
83/upgrade_substrate_dep_v14
branch
from
4175fcc to
163f0b9
Compare
Closed
This was referenced Dec 2, 2021
brenzi
approved these changes
Dec 6, 2021
echevrier
added a commit
that referenced
this pull request
Dec 8, 2021
* upgrade to substrate to 7406442bea0194ffcafc4e8d48d895d4d8d11346 * for v14 metadata * upgrade to subwasm_version 0.14.1 * Update weights function name for pallet teerex according to PR#14 * Add weight for the teeracle Co-authored-by: echevrier <edith.chevrier@scs.ch> Co-authored-by: Bigna Härdi <bhaerdi@devsgx02.scs-ad.scs.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #83
This branch must not be merged to master!!! until integritee-network/worker#484 is done