Polkadot update v0.9.42#175
Merged
OverOrion merged 10 commits intointegritee-network:masterfrom May 31, 2023
Merged
Conversation
Closed
Contributor
Author
|
Did the required followup changes, but now there is an internal substrate error: The error originates from Currently investigating why this happened. |
OverOrion
force-pushed
the
szp/polkadot-update-v0.9.42
branch
from
fc03e5b to
4cb528d
Compare
clangenb
reviewed
May 29, 2023
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
I could imagine that the error comes from divergent substrate versions.
coax1d
reviewed
May 30, 2023
Contributor
coax1d
left a comment
coax1d
left a comment
There was a problem hiding this comment.
All of this looks good to me. All the fun polkadot update stuff.
clangenb
approved these changes
May 30, 2023
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Nice, looks good to me! Now we just have to fix the test.
…existential deposit (ED) Co-authored-by: coax1d <andrewburger1991@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the following substrate PRs for details:
Weight::from_{ref_time, proof_size}paritytech/substrate#13475For the last one I opted for suppressing the warning, but will open an issue for benchmarking it.
Closes #172