Merged
Conversation
clangenb
approved these changes
Jun 7, 2023
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Beautiful, simple and easy
Contributor
Author
|
@clangenb I added an event for the parentchain pallet is this ok? |
Contributor
clangenb
approved these changes
Jun 7, 2023
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Nice, locks great to me!
clangenb
requested changes
Jun 7, 2023
clangenb
reviewed
Jun 7, 2023
Contributor
Author
I can add #179 into this one as well but not sure if there is some additional work to get this accomplished which takes longer than we need in order to sneak this into the release. |
Contributor
Author
|
Think i got the report handled in #179 lmk |
brenzi
requested changes
Jun 8, 2023
brenzi
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #174
closes #179
Some dispatchables are missing events..